Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: vscode.workspace.getWorkspaceFolder(file)` don\'t return workspace folder when file open from command line #108095

Closed
bpasero opened this issue Oct 5, 2020 · 0 comments
Assignees
Labels
unit-test-failure windows VS Code on Windows issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 5, 2020

This test started to fail on Windows from master recently. I think some of the green checks from the commit history are not valid because they do not contain a VSCode build.

 1) ExtHostWorkspace `vscode.workspace.getWorkspaceFolder(file)` don't return workspace folder when file open from command line. #36221:
     TypeError: call.getFileName is not a function
      at getErrMessage (assert.js:270:25)
      at innerOk (assert.js:361:17)
      at Function.ok (assert.js:381:3)
      at Context.<anonymous> (file:///C:/GitDevelopment/monaco/out/vs/workbench/test/browser/api/extHostWorkspace.test.js:471:24)
@bpasero bpasero added windows VS Code on Windows issues unit-test-failure labels Oct 5, 2020
@jrieken jrieken added this to the October 2020 milestone Oct 5, 2020
@jrieken jrieken closed this as completed Oct 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
unit-test-failure windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

2 participants