Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on the edge of the SCM input box causes it to lose focus #108160

Closed
eamodio opened this issue Oct 6, 2020 · 1 comment
Closed

Clicking on the edge of the SCM input box causes it to lose focus #108160

eamodio opened this issue Oct 6, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Oct 6, 2020

I don't know why, but I often seem to click in a space in the input box that causes the focus to be lost.

scm-input

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Oct 6, 2020
@joaomoreno joaomoreno added this to the October 2020 milestone Oct 6, 2020
@joaomoreno
Copy link
Member

joaomoreno commented Oct 6, 2020

I've added a click logger in devtools:

e = window.addEventListener('click', e => console.log(e.target), true)

Which tells me it's view-lines monaco-mouse-cursor-text that's being hit. @alexdima shouldn't the editor take that as a focus intention? Here's what I found when debugging, notice all the false values, when the editor is trying to figure out what's hit:

image

When clicking right in the middle of the editor content area I get targetIsContent as true. But when hitting view-lines, everything is declared as false.

@joaomoreno joaomoreno modified the milestones: October 2020, Backlog Oct 26, 2020
@joaomoreno joaomoreno assigned eamodio and unassigned joaomoreno Nov 11, 2020
@alexdima alexdima modified the milestones: Backlog, November 2020 Nov 12, 2020
@bpasero bpasero added the verified Verification succeeded label Dec 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@joaomoreno @eamodio @bpasero @alexdima and others