Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

References view: clicking refresh seems to run previous search from history #109293

Closed
Tracked by #212907
bpasero opened this issue Oct 24, 2020 · 1 comment
Closed
Tracked by #212907

References view: clicking refresh seems to run previous search from history #109293

bpasero opened this issue Oct 24, 2020 · 1 comment
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders references-viewlet verified Verification succeeded
Milestone
October 2020

Comments

@bpasero
Copy link
Member

bpasero commented Oct 24, 2020

Steps to Reproduce:

  1. (I am using web, not sure if relevant)
  2. find references
  3. find references again on a different symbol
  4. click the refresh button

=> 馃悰 previous references are shown

recording
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug references-viewlet labels Oct 24, 2020
@jrieken jrieken added this to the October 2020 milestone Oct 26, 2020
@jrieken
Copy link
Member

jrieken commented Oct 26, 2020

It's actually the first history entry. Surprised that this was caught only now

jrieken added a commit to microsoft/vscode-references-view that referenced this issue Oct 26, 2020
@jrieken
use last, not first history entry, microsoft/vscode#109293
8bbf89f
jmannanc pushed a commit to jmannanc/vscode that referenced this issue Oct 26, 2020
@jrieken @jmannanc
adopt latest version of ref-viewlet, fixes microsoft#109293
54b9740
@bpasero bpasero added the verified Verification succeeded label Oct 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders references-viewlet verified Verification succeeded
Projects
None yet
Milestone
October 2020
Development

No branches or pull requests
3 participants
@bpasero @jrieken and others