Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid predictions should be invalidated after some timeout #109617

Closed
Tyriar opened this issue Oct 28, 2020 · 0 comments
Closed

Invalid predictions should be invalidated after some timeout #109617

Tyriar opened this issue Oct 28, 2020 · 0 comments
Assignees
@Tyriar @connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues terminal-local-echo Relating to the terminal's local echo and line editing for remote windows verified Verification succeeded
Milestone
November 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2020

Repro:

  1. Connect to Windows SSH window
  2. Open powershell
  3. Type something
  4. Press right, the prediction is the cursor will move, but the pty doesn't send any data as a result so it doesn't get rolled back until something else is pressed

recording (12)

If we have an accurate estimate of latency, maybe double or triple that as the timeout?
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-local-echo Relating to the terminal's local echo and line editing for remote windows labels Oct 28, 2020
@connor4312 connor4312 added this to the November 2020 milestone Oct 28, 2020
@JacksonKearl JacksonKearl added the verified Verification succeeded label Dec 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues terminal-local-echo Relating to the terminal's local echo and line editing for remote windows verified Verification succeeded
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
4 participants
@Tyriar @connor4312 @JacksonKearl and others