IconLabel markdown title debt #109914
IconLabel markdown title debt #109914
Conversation
| @@ -301,3 +301,73 @@ function getInsaneOptions(options: { readonly isTrusted?: boolean }): InsaneOpti | |||
| }; | |||
| } | |||
|
|
|||
| export function RenderMarkdownAsPlaintext(markdown: IMarkdownString) { | |||
There was a problem hiding this comment.
@mjbvz would you be able to review this function?
|
@bpasero I think I have addressed your feedback. |
| @@ -301,3 +301,73 @@ function getInsaneOptions(options: { readonly isTrusted?: boolean }): InsaneOpti | |||
| }; | |||
| } | |||
|
|
|||
| export function renderMarkdownAsPlaintext(markdown: IMarkdownString) { | |||
There was a problem hiding this comment.
So this function is meant to strip all the markup from the string? So # Header would just be rendered as Header?
Just want to check because we also have logic to escape markdown content:
vscode/src/vs/base/common/htmlContent.ts
Line 49 in 983ced6
# Header as # Header
The change itself looks good. If renderMarkdownAsPlaintext is the right approach, then just add a doc comment on it so its behavior is more clear
| if (value.length > 100_000) { | ||
| value = `${value.substr(0, 100_000)}…`; | ||
| } | ||
| return marked.parse(value, { renderer }); |
There was a problem hiding this comment.
Maybe just in case, the output should be passed through our html sanitizer (insane) too
There was a problem hiding this comment.
Good point. Added a call to sanitizeRenderedMarkdown.
Fixes #109231