Git: Investigate using vscode.open and vscode.diff as commands in scm

[joaomoreno]

Currently SCM has a custom mechanism for opening resources: SCM providers provide a command for each resource (git provides git.openResource) and it does some magic behind the scenes to be sure that command gets passed the right Resource when invoked. But this custom approach can never align with all the UI gestures and settings related to editor opening actions (preview, to side, etc).

We should investigate whether its feasible for git to simply provide vscode.open and vscode.diff as the Resource opening commands. That way the core can gives us all the preview, open to side, features.

Related:

• TreeDataProvider: allow single click and double click to work the same way they do in the file exporer  #85636 (comment)
• Preview Editor setting not always applied in Source Control panel #109393

[bpasero]

I landed my changes, if an extension is using vscode.open or vscode.diff for TreeItem, we pass over the context of the list.

To adopt this in SCM, we need something similar like this code right before we invoke the command of a SCM tree item:

vscode/src/vs/workbench/contrib/views/browser/treeView.ts

Lines 468 to 475 in 630e706

	let args = command.arguments || [];
	if (command.id === API_OPEN_EDITOR_COMMAND_ID || command.id === API_OPEN_DIFF_EDITOR_COMMAND_ID) {
	// Some commands owned by us should receive the
	// `IOpenEvent` as context to open properly
	args = [...args, e];
	}
	this.commandService.executeCommand(command.id, ...args);

The fact that this is currently hardcoded inside treeView is a bit of a hack, but I am open for ideas how to make this cleaner once we use it in more places.

[joaomoreno]

Thanks @bpasero, looks awesome!

[joaomoreno]

@bpasero Check it out:

ed4d86e#diff-a29d112f7e1fecae5536543510588375d7283d06e96a4cf64325e8b600f30356R1940-R1941

It is mostly working with some very weird behavior, on which I will need your help next week:

[joaomoreno]

@eamodio Let me know if you'd like a tour of these changes, since they are deep.