Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git/SCM: Use vscode.open and vscode.diff for a better editor opening experience #110733

Merged
merged 7 commits into from Nov 16, 2020
Merged

Git/SCM: Use vscode.open and vscode.diff for a better editor opening experience #110733

merged 7 commits into from Nov 16, 2020

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Nov 16, 2020 •
edited

This PR fixes #110397

cc @bpasero @jrieken @eamodio

@joaomoreno joaomoreno added git GIT issues ux User experience issues scm General SCM compound issues labels Nov 16, 2020
@joaomoreno joaomoreno added this to the November 2020 milestone Nov 16, 2020
@joaomoreno joaomoreno self-assigned this Nov 16, 2020
@joaomoreno joaomoreno merged commit 62e830b into master Nov 16, 2020
@joaomoreno joaomoreno deleted the joao/git/vscode.open branch November 16, 2020 15:19
meganrogge pushed a commit that referenced this pull request Nov 18, 2020
@joaomoreno @meganrogge
Git/SCM: Use vscode.open and vscode.diff for a better editor opening …
e87a631 
…experience (#110733)

* wip: try to use vscode.open and vscode.diff in git/scm

related to #110397

* 💄

* revert change to commands.converter.toInternal

* complete usage os vscode.open and vscode.diff in git extension
@xqzlgy2 xqzlgy2 mentioned this pull request Dec 18, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

Labels
git GIT issues scm General SCM compound issues ux User experience issues
Projects
None yet
Milestone
November 2020
Development

Successfully merging this pull request may close these issues.

Git: Investigate using vscode.open and vscode.diff as commands in scm
1 participant
@joaomoreno