Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VF - Inline javascript and CSS commenting uses <!-- --> erroneously #198

Closed
gbutt opened this issue Oct 31, 2017 · 1 comment
Closed

VF - Inline javascript and CSS commenting uses <!-- --> erroneously #198

gbutt opened this issue Oct 31, 2017 · 1 comment

Comments

@gbutt
Copy link

gbutt commented Oct 31, 2017

Summary

When editing a visualforce page, when I comment out a line of javascript, I expect the language service to use the // for javascript, however it is using <!-- -->.

Steps To Reproduce:

  1. Open a VF page
  2. Add a script tag
  3. Add some javascript
  4. Use keyboard shortcut to comment out a line of javascript

Expected result

Javascript comments should use //.

Actual result

Javascript is commented out with <!-- -->.

Additional information

Feel free to attach a screenshot.

Extension version: 41.5.0

VS Code Version: 1.17.2

SFDX CLI Version: 6.0.9-3391781

OS and version: OSX 10.12.6

@vazexqi vazexqi changed the title VF - Inline javascript commenting not working VF - Inline javascript and CSS commenting uses <!-- --> erroneously Oct 31, 2017
@vazexqi
Copy link
Contributor

vazexqi commented Oct 31, 2017

This is related to microsoft/vscode#11081 (which is fixed) I must have configured this wrongly when I converted the visualforce grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants