Inline action for "edit condition" action in Breakpoints view

[isidorn]

As @bpasero suggested we could use an inline action for the "Edit Condition" action in the breakpoints view.
This inline action would appear on hover for exception breakpoints, function breakpoints, data breakpoints.

Currently we only allow to edit conitions once debugging is started and we know what debug adapter we are using. And we only show these actions if the debug adapter supports the corresponding capabilites. We might also want to consider to show this actions also when not debugging.

fyi @connor4312 @weinand
@misolori for icon ideas

[weinand]

Yes, enabling to edit the condition outside of a debug session would be helpful because it makes the feature more discoverable. In addition it better aligns exception breakpoints with source breakpoints which already support 7/24 condition editing.

(Clarification: exception breakpoints are provided by a DA on "first contact" and then they are shown as long as the same DA is used. So condition editing should only be enabled if the DA has returned the corresponding capabilities on first contact and then this enablement is persisted and can be used outside of a debug session)

And using inline actions is another thing to try (but only after implementing the 7/24 condition editing).

[isidorn]

Makes sense, let me assign to Jaunary to investigate more into this.

[miguelsolorio]

For icon, i'd suggest using our standard edit icon:

[isidorn]

@misolori makes good sense, thanks!

[isidorn]

I just verified that we actually already have 24/7 condition editing, seems like I was thinking about when coding this up before Christmas break 👏
It just took me some time to figure out that I need the js-debug-nightly for the condition editing. @connor4312 do we plan to release this in the js-debug regular release?

Since we have the 24/7 condition editing, I will now look to add the inline action using the Icon Miguel proposed.

[weinand]

@isidorn yes indeed, Mock Debug has 24/7 condition editing.

[isidorn]

Here's how this looks in practice. I will render this inline action for all breakpoints since all breakpoints support conditions now.

[yannickowow]

Hi,
I don't know if you were facing it yet, but, when debugging, I cannot use Edit Hit Count or Edit Condition from actions menu, but I can use pencil icon to edit condition.
When not debugging, it seems to work fine and usage is intuitive.
My debugger supports conditionalBreakpoints, hitConditionalBreakpoints and functionBreakpoints
See:

Regards.

[isidorn]

@yannickowow thanks a lot for trying it out and for providing feedback. I have just pushed a fix for this issue which you found. Thanks!

[yannickowow]

Hi
I did found a bug associated to "Edit Condition" for DataBreakpoints. It shows "Edit Condition" action but it does not open "Edit" view. Edit icon is not displayed as well.
It works fine actually with FunctionBreakpoints.

Thanks!

[isidorn]

@yannickowow that's a good catch. However for now we simply did not implement this, I was not aware of debuggers that would want condition on data breakpoints. Though I see that it makes good sense.
For this I have created a new feature request and I can look into it if there is demand
#114903

[yannickowow]

Thanks.
Since DataBreakpoints implementation in DebugAdapterProtocol supports the same arguments (ie Hit Count and Condition), it would be great if VS Code can show an unified attribute for this.