Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support flow control for the terminal process #113827

Closed
Tyriar opened this issue Jan 5, 2021 · 1 comment
Closed

Support flow control for the terminal process #113827

Tyriar opened this issue Jan 5, 2021 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
feature-request Request for new features or functionality on-testplan perf terminal Integrated terminal issues
Milestone
January 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 5, 2021

This issue is the flow control and event batching part of #74620

Right now web and remote has problems when the terminal produces a lot of data, we need a flow control mechanism to avoid node-pty and its process from getting too far ahead of xterm.js. Event batching will help this by reducing the overall number of messages in favor of larger messages containing multiple data events.
@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues perf labels Jan 5, 2021
@Tyriar Tyriar added this to the January 2021 milestone Jan 5, 2021
@Tyriar Tyriar mentioned this issue Jan 5, 2021
Closed
@kieferrm kieferrm mentioned this issue Jan 5, 2021
Closed
73 tasks
Tyriar added a commit that referenced this issue Jan 12, 2021
@Tyriar
Basic flow control for ext host processes
6430ee1 
Part of #113827
This was referenced Jan 12, 2021
Merged
Closed
Closed
@Tyriar Tyriar self-assigned this Jan 14, 2021
This was referenced Jan 14, 2021
Closed
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jan 14, 2021 •
edited by meganrogge

Left to do:

  • Verify the numbers work well in Codespaces
  • Switch setting default to true (after verifying)

I was thinking about not having a setting but since it's here we can keep it for at least a month just in case there's an issue with it.

lszomoru pushed a commit that referenced this issue Jan 15, 2021
@Tyriar @lszomoru
Basic flow control for ext host processes
93b30ff 
Part of #113827
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality on-testplan perf terminal Integrated terminal issues
Projects
None yet
Milestone
January 2021
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge