Fix: selecting entry should focus back to editor

[susiwen8]

This PR fixes #106824

If active editor wasn't focused after selection, then manually focus editor.

[chrmarti]

Would it make sense to move this to ChangeModeAction? That way we know it is only triggered when the user went through the picker UI.

[susiwen8]

Would it make sense to move this to ChangeModeAction? That way we know it is only triggered when the user went through the picker UI.

Yes, It makes more sense.

[bpasero]

Since there are more pickers for which this issue exists (e.g. changing encoding), I wonder if this should be added to all for consistency?

[susiwen8]

Since there are more pickers for which this issue exists (e.g. changing encoding), I wonder if this should be added to all for consistency?

@bpasero Sure.

[bpasero]

I would have expected the code to focus the active editor after each individual picker, not in that place. Maybe I am missing something? Shouldn't the focus happen after the user picked something from quick pick?

[susiwen8]

I would have expected the code to focus the active editor after each individual picker, not in that place. Maybe I am missing something? Shouldn't the focus happen after the user picked something from quick pick?

@bpasero Yes, that's right, after user pick something from quick pick, active editor should been focused. But somehow, for some quick pick, selecting by mouse click or enter is kind of different.

For mouse click, document.activeElement become editor after selection, but status bar for enter(some cases). That's why I decided to manually focus editor after each select if editor weren't focused.

doRenderNow is the 'converge' function where all post selection action would cross. So I have put logic here.

Kapture.2021-01-18.at.22.42.00.mp4

[bpasero]

@susiwen8 that is the thing I question

doRenderNow is the 'converge' function where all post selection action would cross. So I have put logic here.

No, it is the function called whenever a label changes in the editor status bar, not when picking something.

[bpasero]

Thanks 👍