-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: selecting entry should focus back to editor #114493
Conversation
Would it make sense to move this to ChangeModeAction? That way we know it is only triggered when the user went through the picker UI. |
Yes, It makes more sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are more pickers for which this issue exists (e.g. changing encoding), I wonder if this should be added to all for consistency?
@bpasero Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected the code to focus the active editor after each individual picker, not in that place. Maybe I am missing something? Shouldn't the focus happen after the user picked something from quick pick?
@bpasero Yes, that's right, after user pick something from quick pick, For
Kapture.2021-01-18.at.22.42.00.mp4 |
@susiwen8 that is the thing I question
No, it is the function called whenever a label changes in the editor status bar, not when picking something. |
Thanks 👍 |
This PR fixes #106824
If active editor wasn't focused after selection, then manually focus editor.