Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make peek view more discoverable #115770

Closed
connor4312 opened this issue Feb 4, 2021 · 1 comment
Closed

Make peek view more discoverable #115770

connor4312 opened this issue Feb 4, 2021 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@connor4312
Copy link
Member

ideas:

  • light bulb icon if cursor on the line
  • open peek action from context menu / codelens?
  • hover action
@connor4312 connor4312 added the testing Built-in testing support label Feb 4, 2021
@connor4312 connor4312 added this to the February 2021 milestone Feb 4, 2021
@connor4312 connor4312 self-assigned this Feb 4, 2021
@connor4312 connor4312 added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Feb 12, 2021
@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Feb 24, 2021
@RMacfarlane RMacfarlane added the verified Verification succeeded label Feb 24, 2021
@RMacfarlane
Copy link
Contributor

@connor4312 I think I'm testing the right thing here based on glancing at the commit, but just want to confirm:

  1. Run a test that fails, a peek view gets shown over the portion that failed ✅ this is discoverable
  2. Close peek view, hover again over the failing part, the error is shown in the hover ✅ this is discoverable

Having it in the hover instead of a peek view seemed a little bit weird to me, I think I prefer your idea of opening the view from a codelens. This feels very close to the references peek view - the reason I saw the hover is that I was looking for a codelens near the line of code

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@connor4312 @RMacfarlane @rzhao271 and others