VSCode becomes unresponsive after pasting filename with many dots in file tree

[ghost]

• VSCode Version: 1.53.0 (commit id: 8490d3d)
• OS Version: Ubuntu 20.04.2 LTS (Kernel: Linux 5.4.0-65-generic)

I stumbled upon this bug by accident when I had the contents of some large file in my clipboard and (not realizing I had these file contents in the clipboard) when I pasted it in the filename of the file explorer of VSCode, it became unresponsive to the point I had to force kill it. In my opinion it is not very critical, not many people with encounter this issue, it was just surprising that my vscode became unresponsive due to this. I tried to locate the source of the issue in the code, but I couldn't find it myself.

Steps to Reproduce:

1. open a directory in VSCode such that you have some file existing in the Explorer
2. copy some filename with many dots to the clipboard. I use python -c "print('a.' * 50000)" | xclip -sel clip for this
3. select the file and click rename F2, followed by CTRL-V to paste the string
4. observe vscode is unresponsive for more than 30 seconds, after which I force kill it.

I found out that when you would paste 100.000 characters without using dots (i.e. python -c "print('ab' * 50000)" | xclip -sel clip), then VSCode responds very quickly and lets me know the filename is invalid.

Since the maximum allowed length of a filename is 255 characters, I think it would suffice to limit the filename to 255 characters before any further parsing is done.

Does this issue occur when all extensions are disabled?: Yes / no

[jrieken]

I can reproduce. Looks like the getIconClasses-function is causing this.

Profile-20210209T161958.json.txt

[jrieken]

my "fill clipboard snippet" is this setTimeout(() => navigator.clipboard.writeText(new Array(50000).fill('a').join('.')), 3000). Open dev-tools, paste and run, and within the 3sec focus the content window

[bpasero]

Since it happens inside the method, like something that was added around here: a84b272

[jeanp413]

I'll take a look at this

[jrieken]

Still quite slow but not freezing anymore