Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: Horizontal scrolling is broken #117221

Closed
joaomoreno opened this issue Feb 22, 2021 · 6 comments
Closed

Search: Horizontal scrolling is broken #117221

joaomoreno opened this issue Feb 22, 2021 · 6 comments

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Feb 22, 2021 •
edited

When enabling horizontal scrolling the search viewlet is completely broken.

It might be doing some weird CSS which escapes the tree horizontal scrolling rules.

I'm pretty sure it was working just fine last time I touched horizontal scrolling.

Similar to #69557
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues tree-widget Tree widget issues labels Feb 22, 2021
@joaomoreno joaomoreno added this to the Backlog milestone Feb 22, 2021
@roblourens
Copy link
Member

This is probably from the other change we were discussing where now I call tree.layout() to let it measure its own container. Do I have to do something different there for horizontal scrolling?

@roblourens
Copy link
Member

f1202da

@andreamah andreamah assigned andreamah and unassigned roblourens Dec 14, 2022
@joaomoreno
Copy link
Member Author

This seems like it's working now.

@joaomoreno joaomoreno closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2022
@joaomoreno joaomoreno removed this from the Backlog milestone Dec 15, 2022
@joaomoreno joaomoreno removed bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues tree-widget Tree widget issues labels Dec 15, 2022
@andreamah
Copy link
Contributor

@joaomoreno I see this when i enable horizontal scrolling. The action buttons are far to the right. Is this expected?

Image from Gyazo

@roblourens
Copy link
Member

Yes, there was another issue suggesting having the buttons float to the left when horizontal scrolling is enabled

@andreamah
Copy link
Contributor

right, it's at #45717

@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joaomoreno @roblourens @andreamah