Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search view with horizontal scrolling #45717

Open
roblourens opened this issue Mar 14, 2018 · 2 comments
Open

Search view with horizontal scrolling #45717

roblourens opened this issue Mar 14, 2018 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality search Search widget and operation issues
Milestone

Comments

@roblourens
Copy link
Member

#15539

I like the horizontal scroll setting but it doesn't work well in the search view. If I have a search result in a long line of text, then I have to scroll very far to see the file count, or the x button, replace button, and file count.

image

Ideally these would be fixed to the right side of the search view container and visible without scrolling. But we may also move them as part of #45063

cc @joaomoreno @isidorn

@roblourens roblourens added feature-request Request for new features or functionality search Search widget and operation issues labels Mar 14, 2018
@roblourens roblourens self-assigned this Mar 14, 2018
@joaomoreno
Copy link
Member

That's exactly the problem with horizontal scrolling. Making the actions "float" is also not pretty since they would be overdrawn on top of the text. The same problem happens with explorer decorations.

Apart from perf this is the other reason why horizontal scrolling isn't enabled by default.

@isidorn
Copy link
Contributor

isidorn commented Mar 14, 2018

This would also be potentially tackled by moving those actions to the left as they are in the open editors view.

@roblourens roblourens added this to the Backlog milestone Oct 27, 2019
@roblourens roblourens modified the milestones: Backlog, On Deck Dec 13, 2022
@andreamah andreamah assigned andreamah and unassigned roblourens Dec 15, 2022
@andreamah andreamah modified the milestones: On Deck, Backlog Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

4 participants