Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make terminal relaunch logic more internal to the process manager #118574

Merged
merged 7 commits into from Mar 11, 2021

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 9, 2021

Fixes #100709

@Tyriar Tyriar added this to the March 2021 milestone Mar 9, 2021
@Tyriar Tyriar self-assigned this Mar 9, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Mar 11, 2021

@alexr00 FYI this refactor affects reuse in tasks, if you see anything weird please let me know but I think the events still fire the same way. I also verified task reuse works manually.

@Tyriar Tyriar merged commit 1ad8c46 into main Mar 11, 2021
@Tyriar Tyriar deleted the tyriar/100709 branch March 11, 2021 16:06
@alexr00
Copy link
Member

alexr00 commented Mar 11, 2021

@Tyriar I see this issue: #118256

I thought maybe your change would fix it, but I still see it.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve how process is managed when the terminal is reused
2 participants