Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When uninstalling an extension, ask to also uninstall extensions that depend on it #119243

Closed
fbricon opened this issue Mar 18, 2021 · 10 comments · Fixed by #221504
Closed

When uninstalling an extension, ask to also uninstall extensions that depend on it #119243

fbricon opened this issue Mar 18, 2021 · 10 comments · Fixed by #221504
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Mar 18, 2021

A user reported that he "Cannot uninstall 'Language Support for Java(TM) by Red Hat' extension. 'Java Test Runner' extension depends on this.", but it's only one extension among many that depend on Java.
Rather than manually hunting down those extensions to uninstall first (which itself is a daunting task, see #119242), the warning popup should provide a button to uninstall all those other extensions (and their dependants) as well.

See redhat-developer/vscode-java#1837

@rpwnage
Copy link
Contributor

rpwnage commented Mar 18, 2021

I‘d like to handle this enhancement

@gjsjohnmurray
Copy link
Contributor

For me the notification lists dependants.

#104997 added the ability to disable the dependants directly from the notification that appears when disabling (rather than uninstalling). Sounds like we want the same on the uninstall.

@fbricon
Copy link
Contributor Author

fbricon commented Mar 18, 2021

the notification lists 2 dependants at most. This is insufficient data.

@gjsjohnmurray
Copy link
Contributor

the notification lists 2 dependants at most. This is insufficient data.

Fair point. But as a workaround you can presumably uninstall the two shown, then try again on the main extension and find out which two (or possibly one) to uninstall next.

@rpwnage
Copy link
Contributor

rpwnage commented Mar 18, 2021

Yes, but I get @fbricon‘s point. Installing every single extension by hand, and rechecking dependencies after removing the two removed extensions by may be kind of annoying.
You‘re trying to make the Pop-up show all dependent extensions, rather then just showing only two, correct?

@gjsjohnmurray
Copy link
Contributor

You‘re trying to

I am unclear who "you" is.

@rpwnage
Copy link
Contributor

rpwnage commented Mar 18, 2021

I was referring to @fbricon

@sandy081
Copy link
Member

I think we provide Disable All button when user tries to disable an extension and there are dependents. We shall do the same for Uninstall

@sandy081 sandy081 added extensions Issues concerning extensions feature-request Request for new features or functionality labels Mar 19, 2021
@sandy081 sandy081 added this to the Backlog milestone Mar 19, 2021
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Dec 6, 2022
@VSCodeTriageBot
Copy link
Collaborator

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
@sandy081 sandy081 removed the *out-of-scope Posted issue is not in scope of VS Code label Jul 3, 2024
@sandy081 sandy081 reopened this Jul 3, 2024
@sandy081 sandy081 modified the milestones: Backlog, July 2024 Jul 3, 2024
sandy081 added a commit that referenced this issue Jul 11, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 11, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 12, 2024
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Jul 22, 2024
@sandy081
Copy link
Member

To verify:

  • Install Java Test Runner vscjava.vscode-java-test extension
  • Uninstalling Language Support for Java extension should show a dialog asking to also uninstall the Java Test Runner Extension

@rzhao271 rzhao271 added the verified Verification succeeded label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants