Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminal mouse reporting via binary events #120145

Merged
merged 17 commits into from Mar 31, 2021
Merged

Fix terminal mouse reporting via binary events #120145

merged 17 commits into from Mar 31, 2021

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Mar 30, 2021

This PR fixes #96058

@meganrogge meganrogge added this to the April 2021 milestone Mar 30, 2021
@meganrogge meganrogge self-assigned this Mar 30, 2021
@meganrogge
Copy link
Contributor Author

It looks correct to me and the event is getting piped through. I think there's something wrong here

this._ptyProcess!.write(Buffer.from(data, 'binary').toString('binary'));

But it takes forever to make a custom build and test in WSL

@meganrogge meganrogge requested a review from Tyriar March 30, 2021 02:39
@Tyriar Tyriar changed the title enable mouse reporting Fix terminal mouse reporting via binary events Mar 30, 2021
@meganrogge meganrogge merged commit d5cf4ac into main Mar 31, 2021
@meganrogge meganrogge deleted the merogge/onBinary branch March 31, 2021 22:57
@nojvek
Copy link
Contributor

nojvek commented Mar 31, 2021

@meganrogge, this is awesome. Thanks for pushing this to the finish line. Very excited that now vscode can do mouse events in terminal.

@meganrogge meganrogge restored the merogge/onBinary branch April 1, 2021 23:10
@meganrogge meganrogge deleted the merogge/onBinary branch April 14, 2021 02:46
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrated terminal mouse reporting not working
4 participants