New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix terminal mouse reporting via binary events #120145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks correct to me and the event is getting piped through. I think there's something wrong here
But it takes forever to make a custom build and test in WSL |
Tyriar
reviewed
Mar 30, 2021
Tyriar
changed the title
enable mouse reporting
Fix terminal mouse reporting via binary events
Mar 30, 2021
Tyriar
requested changes
Mar 30, 2021
src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/remoteTerminalService.ts
Outdated
Show resolved
Hide resolved
…er.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Tyriar
approved these changes
Mar 31, 2021
src/vs/workbench/contrib/terminal/browser/terminalProcessExtHostProxy.ts
Show resolved
Hide resolved
@meganrogge, this is awesome. Thanks for pushing this to the finish line. Very excited that now vscode can do mouse events in terminal. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #96058