Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TerminalOptions.icon API to support tabs in terminal #120538

Closed
Tyriar opened this issue Apr 5, 2021 · 4 comments · Fixed by #124004 or #125783
Closed

Add TerminalOptions.icon API to support tabs in terminal #120538

Tyriar opened this issue Apr 5, 2021 · 4 comments · Fixed by #124004 or #125783
Assignees
@Tyriar @meganrogge
Labels
api api-finalization feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan terminal Integrated terminal issues
Milestone
June 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 5, 2021

#120241
@Tyriar Tyriar added feature-request Request for new features or functionality api terminal Integrated terminal issues api-proposal labels Apr 5, 2021
@Tyriar Tyriar added this to the April 2021 milestone Apr 5, 2021
@Tyriar Tyriar self-assigned this Apr 5, 2021
Tyriar added a commit that referenced this issue Apr 5, 2021
@Tyriar
Add terminal icon ext api
f881011 
Part of #120538
This was referenced Apr 5, 2021
Merged
Closed
@jrieken
Copy link
Member

jrieken commented Apr 7, 2021

vscode/src/vs/vscode.d.ts

Line 9165 in 16cff9c

iconPath?: string | Uri | { light: string | Uri; dark: string | Uri } | ThemeIcon;

@jrieken
Copy link
Member

jrieken commented Apr 7, 2021

vscode/src/vs/vscode.d.ts

Line 7436 in 16cff9c

iconPath?: Uri | { light: Uri; dark: Uri };

@Tyriar
Copy link
Member Author

Tyriar commented Apr 7, 2021

New proposal:

interface TerminalOptions {
  iconPath?: Uri | { light: Uri; dark: Uri } | ThemeIcon;
}

digitarald pushed a commit that referenced this issue Apr 8, 2021
@Tyriar @digitarald
Add terminal icon ext api
7ab966c 
Part of #120538
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Apr 8, 2021
@Tyriar @gjsjohnmurray
Add terminal icon ext api
522627a 
Part of microsoft#120538
@Tyriar Tyriar modified the milestones: April 2021, May 2021 Apr 24, 2021
@meganrogge meganrogge mentioned this issue Apr 26, 2021
Closed
3 tasks
@Tyriar
Copy link
Member Author

Tyriar commented May 13, 2021

We should also add it to ExtensionTerminalOptions

@meganrogge meganrogge mentioned this issue May 19, 2021
Merged
@Tyriar Tyriar reopened this May 20, 2021
@meganrogge meganrogge modified the milestones: May 2021, June 2021 May 21, 2021
@meganrogge meganrogge mentioned this issue May 21, 2021
Closed
3 tasks
@meganrogge meganrogge mentioned this issue Jun 8, 2021
Merged
@Tyriar Tyriar mentioned this issue Jun 25, 2021
Closed
3 tasks
@meganrogge meganrogge added the on-release-notes Issue/pull request mentioned in release notes label Jul 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
api api-finalization feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan terminal Integrated terminal issues
Projects
None yet
Milestone
June 2021
Development

Successfully merging a pull request may close this issue.

Terminal tab icon API microsoft/vscode
finalize terminal iconPath microsoft/vscode
4 participants
@jrieken @Tyriar @meganrogge and others