Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky notebook test: set outputs #122851

Closed
bpasero opened this issue May 3, 2021 · 2 comments
Closed

Flaky notebook test: set outputs #122851

bpasero opened this issue May 3, 2021 · 2 comments

Comments

@bpasero
Copy link
Member

bpasero commented May 3, 2021

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=116579&view=logs&j=4d2898ab-dfbe-557e-92e7-aaac158fdd2f&t=b2ac4860-fb3b-5a51-42a7-7423ead0721b&l=363

1) Notebook API tests
       set outputs on interrupt:
     Error: asPromise TIMEOUT reached
      at Timeout._onTimeout (extensions/vscode-api-tests/src/utils.ts:130:11)
      at listOnTimeout (internal/timers.js:554:17)
      at processTimers (internal/timers.js:497:7)

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=116584&view=logs&j=672276a2-8d3a-5fab-615d-090c51352f92&t=c55167a9-8752-5898-67fa-9d7c918c61b3&l=357

  1 failing
  1) Notebook API tests
       set outputs on cancel:

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  [
+   'my output'
-   'Canceled'
  ]
      + expected - actual

       [
      -  "my output"
      +  "Canceled"
       ]
      
      at D:\a\1\s\extensions\vscode-api-tests\src\singlefolder-tests\notebook.test.ts:819:11
      at withEvent (D:\a\1\s\extensions\vscode-api-tests\src\singlefolder-tests\notebook.test.ts:57:2)
      at Context.<anonymous> (D:\a\1\s\extensions\vscode-api-tests\src\singlefolder-tests\notebook.test.ts:812:3)
@bpasero bpasero changed the title Flaky notebook test Flaky notebook test: set outputs May 3, 2021
@rebornix rebornix assigned jrieken and unassigned rebornix May 3, 2021
@jrieken
Copy link
Member

jrieken commented May 6, 2021

Feeling lucky... Closing because we are using more strict API now and there is more assertions that should tell us more about why/how this fails (if this fails again)

@jrieken jrieken closed this as completed May 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants
@rebornix @bpasero @jrieken and others