Replace WMIC call with a supported solution

[danielgary]

WMIC is deprecated and has been for some time. Currently it is used for determining if any integrated terminal instances have any child processes.

vscode/src/vs/workbench/contrib/debug/node/terminals.ts

Line 55 in 25d1c0b

return spawnAsPromised('wmic', ['process', 'get', 'ParentProcessId']).then(stdout => {

There are PowerShell commands that can return the count of child processes given a parent process ID, but I'm not sure what the performance hit for using PowerShell would be.

[riverar]

Windows doesn't maintain strong parent/child process relationships, so the design here needs some more thinking.

If you're feeling gangster, you can call NtQueryInformationProcess with PROCESS_BASIC_INFORMATION and dig out the undocumented InheritedFromUniqueProcessId member.

But I wouldn't bother, because you then need to consider the process ID you retrieved could have already been recycled and now points to something else entirely.

[danielgary]

Thanks for all the help @riverar !