Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced wmic call with windows-process-tree #123895

Merged
merged 2 commits into from May 18, 2021
Merged

Replaced wmic call with windows-process-tree #123895

merged 2 commits into from May 18, 2021

Conversation

danielgary
Copy link
Contributor

@danielgary danielgary commented May 14, 2021 •
edited

This PR fixes #123296

According to https://github.com/microsoft/vscode-windows-process-tree, this has performance benefits as well as not being dependent on WMIC.

Tyriar
Tyriar approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the usage looks fine, will leave this for @weinand for final review

@Tyriar Tyriar added this to the May 2021 milestone May 14, 2021
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 18, 2021
@weinand weinand merged commit 026e623 into microsoft:main May 18, 2021
@danielgary danielgary deleted the wmic-replacement branch May 18, 2021 13:46
@weinand
Copy link
Contributor

weinand commented May 18, 2021

@danielgary thanks for the PR!

@danielgary
Copy link
Contributor Author

Thanks for the approval!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weinand weinand weinand approved these changes

@Tyriar Tyriar Tyriar approved these changes

Assignees

@weinand weinand

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
May 2021
Development

Successfully merging this pull request may close these issues.

Replace WMIC call with a supported solution
3 participants
@danielgary @weinand @Tyriar