Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Getting Started] Reset Getting Started to correct state when opening workspace #123525

Closed
digitarald opened this issue May 11, 2021 · 3 comments · Fixed by #130892
Closed

[Getting Started] Reset Getting Started to correct state when opening workspace #123525

digitarald opened this issue May 11, 2021 · 3 comments · Fixed by #130892
Assignees
@JacksonKearl
Labels
feature-request Request for new features or functionality getting-started insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2021

Comments

@digitarald
Copy link
Contributor

digitarald commented May 11, 2021 •
edited

STR:

  1. Open an empty VS Code
  2. Open a project from the Getting Started / Setup flow using the last step

Another STR that should work for this would be the C++ extension, also prompting the user to open a C++ projoct folder.

AR: Re-opens Getting Started / Setup, but with first step selected.

ER: Select the last used step.

The STR also depends on the Open your project folder from a when to a doneOn after #122570 lands; so it doesn't just go away after being triggered.
@digitarald
Copy link
Contributor Author

Brought up by @jureid for the C++ extension walkthrough (#118402)

@JacksonKearl JacksonKearl added the feature-request Request for new features or functionality label May 12, 2021
@JacksonKearl JacksonKearl added this to the May 2021 milestone May 12, 2021
@JacksonKearl JacksonKearl removed this from the May 2021 milestone May 26, 2021
@JacksonKearl JacksonKearl removed feature-request Request for new features or functionality getting-started labels May 26, 2021
@JacksonKearl JacksonKearl added this to the May 2021 milestone May 26, 2021
@JacksonKearl JacksonKearl added bug Issue identified by VS Code Team member as probable bug getting-started feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels May 26, 2021
@JacksonKearl JacksonKearl removed their assignment May 26, 2021
@JacksonKearl JacksonKearl removed the feature-request Request for new features or functionality label May 26, 2021
@JacksonKearl JacksonKearl removed this from the May 2021 milestone May 26, 2021
@JacksonKearl JacksonKearl self-assigned this May 26, 2021
@JacksonKearl JacksonKearl added this to the May 2021 milestone May 26, 2021
@JacksonKearl JacksonKearl added the feature-request Request for new features or functionality label May 26, 2021
@JacksonKearl JacksonKearl removed their assignment May 26, 2021
@JacksonKearl JacksonKearl removed this from the May 2021 milestone May 26, 2021
@JacksonKearl JacksonKearl removed the feature-request Request for new features or functionality label May 26, 2021
@JacksonKearl JacksonKearl added this to the May 2021 milestone May 26, 2021
@JacksonKearl JacksonKearl self-assigned this May 26, 2021
@JacksonKearl JacksonKearl added the feature-request Request for new features or functionality label May 26, 2021
@JacksonKearl JacksonKearl modified the milestones: May 2021, Backlog Jun 1, 2021
@alexweininger
Copy link
Member

+1 for this feature. It would help us create a better walkthrough for the Azure Static Web Apps extension microsoft/vscode-azurestaticwebapps#397

@JacksonKearl JacksonKearl mentioned this issue Aug 13, 2021
Closed
@JacksonKearl JacksonKearl removed this from the Backlog milestone Aug 13, 2021
@JacksonKearl JacksonKearl added this to the August 2021 milestone Aug 13, 2021
JacksonKearl pushed a commit that referenced this issue Aug 16, 2021
Lots of cleanup in to getting started.
17a00c7 
More still needed but good preogress.
Fixes #123525
Fixes #125354
Fixes #127510
@JacksonKearl JacksonKearl mentioned this issue Aug 16, 2021
Merged
JacksonKearl pushed a commit that referenced this issue Aug 16, 2021
Lots of cleanup in to getting started. (#130892)
2a7b4d5 
More still needed but good preogress.
Fixes #123525
Fixes #125354
Fixes #127510
@egamma egamma mentioned this issue Aug 16, 2021
Closed
91 tasks
AiverReaver pushed a commit to AiverReaver/vscode that referenced this issue Aug 19, 2021
@AiverReaver
Lots of cleanup in to getting started. (microsoft#130892)
a5987ab 
More still needed but good preogress.
Fixes microsoft#123525
Fixes microsoft#125354
Fixes microsoft#127510
@JacksonKearl JacksonKearl added the verification-needed Verification of issue is requested label Aug 24, 2021
@alexr00
Copy link
Member

alexr00 commented Aug 25, 2021 •
edited

I verified by:

  1. Open a folder in VS Code
  2. Open the Help: Welcome view
  3. Open a walkthrough and do a few steps
  4. Close folder
  5. Open the Help: Welcome view
  6. From there, open the same folder I was just in from the Recents list
  7. See the Welcome view is opened to the same task I stopped on.

@alexr00 alexr00 added the verified Verification succeeded label Aug 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
feature-request Request for new features or functionality getting-started insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

Successfully merging a pull request may close this issue.

Lots of cleanup in to getting started. microsoft/vscode
5 participants
@digitarald @JacksonKearl @alexweininger @alexr00 and others