Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot split local terminal with docker terminal #123926

Closed
ghost opened this issue May 15, 2021 · 6 comments
Closed

Cannot split local terminal with docker terminal #123926

ghost opened this issue May 15, 2021 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@ghost
Copy link

ghost commented May 15, 2021

Does this issue occur when all extensions are disabled?

N/A because this can't be reproduced without the Remote-Containers extension.
I understand that "Issues caused by an extension need to be reported directly to the extension publisher," but this isn't actually an issue with the extension, it's an issue with the vscode integrated terminal.

Specs

  • VS Code Version: 1.56.2
  • OS Version: Ubuntu 20.04 (x64, kernel 5.8.0)

Steps to Reproduce

  1. Open your workspace in a Docker container using a devcontainer.json file.
  2. In the command palette, run Terminal: Create New Integrated Terminal (Local)
  3. In the terminal click on the split icon. You will see an error message saying that your local home folder doesn't exist on the Docker container.

This error should occur so long as the user running vscode does not exist in the Docker container.

@ghost
Copy link
Author

ghost commented Jun 3, 2021

Any update on this?
Ping @Tyriar

@Tyriar
Copy link
Member

Tyriar commented Jun 3, 2021

I can't repro in Insiders, mac should work the same as Linux. This might have been fixed by something else?

recording (6)

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Jun 3, 2021
@ghost
Copy link
Author

ghost commented Jun 4, 2021

I am able to reproduce the error. Here is a gif:
Error

I've blacked out my username but the blacked out part is just /home/username.

@Tyriar
Copy link
Member

Tyriar commented Jun 4, 2021

Thanks for the gif, can repro. This affects the split command only, splitInstance works which powers the tab split button I was using.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues and removed info-needed Issue requires more information from poster labels Jun 4, 2021
@Tyriar Tyriar added this to the May 2021 milestone Jun 4, 2021
@Tyriar Tyriar modified the milestones: May 2021, June 2021 Jun 4, 2021
@ghost
Copy link
Author

ghost commented Jun 14, 2021

This affects the split command only, splitInstance works which powers the tab split button I was using.

Out of curiosity, what is the difference between split and splitInstance?

Can I work around this issue for the moment by using a different command and triggering splitInstance instead of split?

@Tyriar
Copy link
Member

Tyriar commented Jun 22, 2021

@applemonkey496 splitInstance is an internal command that uses the selected terminal tabs in the tab view, it's what drives this context menu:

Screen Shot 2021-06-22 at 5 38 25 AM

@Tyriar Tyriar closed this as completed in 904043b Jun 22, 2021
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @TylerLeonhardt @meganrogge and others