Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cell collapsed state a UI properly #125274

Closed
jrieken opened this issue Jun 2, 2021 · 4 comments
Closed

Make cell collapsed state a UI properly #125274

jrieken opened this issue Jun 2, 2021 · 4 comments
Assignees
Labels
api debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook-api
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jun 2, 2021

We have done some last minute clean-up and removes collapse states from cell metadata. This was an API only change and needs further clean-up. We

  • define collapsed state as a view property (not a model property)
  • expose the view state via the NotebookEditor API (set/get property and event)
@tanhakabir
Copy link
Contributor

Do we still need this? @jrieken

@jrieken
Copy link
Member Author

jrieken commented Oct 5, 2021

Yes, pretty sure because at the time we made this an API only change, e.g the data is still there and used wrongly. Tho @roblourens will know best.

@roblourens roblourens added the debt Code quality issues label Oct 13, 2021
@roblourens roblourens added this to the Backlog milestone Oct 13, 2021
@rebornix rebornix removed the notebook label Oct 21, 2021
@roblourens
Copy link
Member

Not actually sure what we want to do with this, because I think we still might want to support Jupyter's feature of persisting this state to share.

@rebornix should I assume that even if we do that, we definitely don't want to use our metadata for that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook-api
Projects
None yet
Development

No branches or pull requests

5 participants
@roblourens @rebornix @jrieken @tanhakabir and others