Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability for extension to Expand/Collapse intput & output of Notebook cells #125308

Closed
DonJayamanne opened this issue Jun 2, 2021 · 3 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@DonJayamanne
Copy link
Contributor

Today we collapse and expand cell input & output using the metadata inputCollapsed and outputCollapsed properties.

I've updated our code base to use the VSC code commands to expand/collapse cell output. We inspect the value of the property outputCollapsed and accordingly fire the command notebook.cell.expandCellOutput or notebook.cell.collapseCellOutput
I.e we're not using the metadata to collapse the cell output.

Question:

  • Should we continue updating the metadata to change the UI state?
  • Should we use the metadata to only inspect the UI state (treat it as a readonly property) & use commands to collapse/expand cell

@jrieken @rebornix /cc

@vscodebot
Copy link

vscodebot bot commented Jun 2, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jrieken
Copy link
Member

jrieken commented Jun 3, 2021

/duplicate of #125274

@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants
@roblourens @rebornix @jrieken @DonJayamanne and others