Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Trust Editor loads slowly and changes state during loading #125319

Closed
digitarald opened this issue Jun 2, 2021 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workspace-trust Trusted workspaces
Milestone

Comments

@digitarald
Copy link
Contributor

Reloading workspace editor on a trusted project, 50% slower:

workspace-loading.mp4

Main issues in the recording, apart from the slow loading:

  1. Loads in restricted mode for a long time, then suddenly toggled to trusted
  2. Main trust/restricted panels take long to load and cause significant layout shift; even though they only contain few dynamic elements
@digitarald digitarald added the workspace-trust Trusted workspaces label Jun 2, 2021
@sbatten sbatten added this to the May 2021 milestone Jun 2, 2021
@sbatten sbatten added the bug Issue identified by VS Code Team member as probable bug label Jun 2, 2021
@sbatten
Copy link
Member

sbatten commented Jun 2, 2021

I think to smooth this out without much change, for now, we just will wait to render until workspace is fully initialized (this is how the workbench indicators operate)

@digitarald
Copy link
Contributor Author

As the UI layout itself is mostly predictable in a rough shape, maybe using css grid could allow building a skeleton loading indicator; so the page doesn't stay blank for multiple seconds.

@sbatten
Copy link
Member

sbatten commented Jun 2, 2021

until the workspace trust state is resolved, nothing except the list of entries at the bottom is truly correct. while I agree we can do more polish on this, I don't think its worth doing this week.

@sbatten sbatten closed this as completed in 4d4f0b5 Jun 2, 2021
@andreamah andreamah added the verified Verification succeeded label Jun 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workspace-trust Trusted workspaces
Projects
None yet
Development

No branches or pull requests

4 participants
@digitarald @sbatten @andreamah and others