Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code Text Explorer prints "null" instead of "undefined" #125669

Closed
hediet opened this issue Jun 7, 2021 · 0 comments
Closed

VS Code Text Explorer prints "null" instead of "undefined" #125669

hediet opened this issue Jun 7, 2021 · 0 comments
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Milestone
July 2021

Comments

@hediet
Copy link
Member

hediet commented Jun 7, 2021

I think it would be cool if the output is actual typescript syntax that can be copy&pasted.
Even better would be an action that fixes the expected value.
Currently, undefined is printed as null, which is very dangerous.

image
@hediet hediet added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Jun 7, 2021
@connor4312 connor4312 added this to the June 2021 milestone Jun 7, 2021
@connor4312 connor4312 modified the milestones: June 2021, July 2021 Jul 1, 2021
@roblourens roblourens added the verified Verification succeeded label Jul 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2021
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@connor4312
testing: fix undefined not being reported correctly in results
3035766 
Fixes microsoft#125669
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
Milestone
July 2021
Development

No branches or pull requests
4 participants
@roblourens @connor4312 @hediet and others