Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotating tab decorations aren't aligned correctly #126819

Closed
Tyriar opened this issue Jun 21, 2021 · 0 comments · Fixed by #126910
Closed

Rotating tab decorations aren't aligned correctly #126819

Tyriar opened this issue Jun 21, 2021 · 0 comments · Fixed by #126910
Assignees
@jrieken @Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug file-decorations insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 21, 2021

recording (24)
Tyriar added a commit that referenced this issue Jun 22, 2021
@Tyriar
Remove padding from icon label to align spin animation
6629d69 
Fixes #126819
Tyriar added a commit that referenced this issue Jun 22, 2021
@Tyriar
Use margin instead of padding for decoration spacing
e84378f 
This makes the spin animation work consistently as margin is not considered
part of the element.

Fixes #126819
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug file-decorations labels Jun 22, 2021
@Tyriar Tyriar added this to the June 2021 milestone Jun 22, 2021
Tyriar added a commit that referenced this issue Jun 22, 2021
@Tyriar
Use margin instead of padding for decoration spacing
b459881 
This makes the spin animation work consistently as margin is not considered
part of the element.

Fixes #126819
@Tyriar Tyriar mentioned this issue Jun 22, 2021
Merged
@rzhao271 rzhao271 added the verified Verification succeeded label Jun 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug file-decorations insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2021
Development

Successfully merging a pull request may close this issue.

Use margin instead of padding for decoration spacing microsoft/vscode
4 participants
@jrieken @Tyriar @rzhao271 and others