Allow svgs in walkthroughs to be clickable

[miguelsolorio]

We previously talked about how it would be great if our SVGs could leverage links to open commands (like opening the extension marketplace) as the extension images in the walkthroughs look clickable:

[miguelsolorio]

Thanks for adding this @JacksonKearl! I was trying to update our svgs to start using this via:

<a xlink:href="command:extension.open?%5Bms-python.python%5D">
	<g filter="url(#filter1_d)">
		<rect x="236" y="316" width="48" height="48" rx="4" fill="white"/>
		<rect x="240" y="320" width="40" height="40" fill="url(#pattern1)"/>
	</g>
</a>

The command was provided by @sandy081 but it sounds like the extensionId argument is not being passed when debugged:

@JacksonKearl do you know why that would be? Other commands work fine but the ones with arguments don't

[JacksonKearl]

@misolori I believe you want "command:extension.open?%22ms-python.python%22", with %22's

This is: encodeURIComponent('"ms-python.python"'), whereas you have encodeURIComponent('[ms-python.python]').

[miguelsolorio]

Aha! Thank you! Looks like this command opens the extension in the extension detail view. Do we have a command to open this in the extensions view like:

EDIT: nvm, I believe it is command:workbench.extensions.search?%22ms-python.python%22 so I think I am good now. Thanks!

[miguelsolorio]

This works 🥳🎉

CleanShot.2021-07-14.at.15.19.53.mp4