Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an overflow design for the status bar #12941

Closed
mousetraps opened this issue Sep 28, 2016 · 10 comments
Closed

Implement an overflow design for the status bar #12941

mousetraps opened this issue Sep 28, 2016 · 10 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality ux User experience issues workbench-status Status bar

Comments

@mousetraps
Copy link
Contributor

Testing #12519

Change window.zoomLevel in settings to 3, and shrink the window a bit until the "responsive" design starts kicking in. Pressing Ctrl+M then toggles the UI between the following two states:
image

This is problematic because

  • there's no indication to the user what just happened or that the mode switch was successful.
  • It's unclear (from a user perspective) why stuff just disappeared from the status bar
@mousetraps
Copy link
Contributor Author

Also, if you toggle into the tab-moves-focus mode, and start tabbing through the UI, eventually the remainder of the status bar will appear (sort of)
image

@joaomoreno
Copy link
Member

Oh my.

@bpasero
Copy link
Member

bpasero commented Sep 29, 2016

I think this is a general issue with the statusbar overflow design that we need to revisit. I think no matter how small the status bar is, we should always show the "Tab Moves Focus" indicator.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 29, 2016
@bpasero bpasero self-assigned this Sep 29, 2016
@bpasero bpasero modified the milestones: September 2016, October 2016 Sep 29, 2016
@bpasero
Copy link
Member

bpasero commented Oct 3, 2016

@mousetraps no matter how small I make the window and zoom, the indicator always has enough space to show (tried on Windows and Mac):

screen shot 2016-10-03 at 09 33 36

@bpasero bpasero modified the milestones: Backlog, October 2016 Oct 3, 2016
@bpasero bpasero added the info-needed Issue requires more information from poster label Oct 3, 2016
@bpasero
Copy link
Member

bpasero commented Oct 3, 2016

@mousetraps needs more info how to reproduce, maybe you hit a corner case where this happened or maybe you have some extension installed that contributes to the status bar?

@bpasero
Copy link
Member

bpasero commented Oct 13, 2016

A number of days has past without answer on the questions asked. I am thereby going to close this issue to clean up our backlog of issues. Once you can answer on the questions, the issue can be reopened again. Thanks for understanding this process!

@bpasero bpasero closed this as completed Oct 13, 2016
@roblourens
Copy link
Member

I can repro this fairly easily. This is with no zoom. But you have to play around with the size a little, and it's different if you have other status bar items. Disabled all the status bar item extensions here.
oct-26-2016 17-57-24

@roblourens
Copy link
Member

I haven't been able to make the status bar scroll up like in the second picture though. #14565 though.

@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Oct 27, 2016
@bpasero bpasero changed the title Ctrl+M toggle updates UI strangely when zoom level is high Implement an overflow design for the status bar Oct 30, 2016
@bpasero bpasero added feature-request Request for new features or functionality ux User experience issues and removed bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities info-needed Issue requires more information from poster labels Oct 30, 2016
@bpasero bpasero removed their assignment Oct 30, 2016
@bpasero bpasero removed this from the Backlog milestone Oct 30, 2016
@sean-mcmanus
Copy link
Contributor

The C++ extension shows the current class/method in the status bar and we want to take up as much space as possible, but when the text is too long it disappears, which is not good because the UI is no longer clickable to invoke the navigation dropdown. It would be great if you guys could implement some text overflow solution that could solve this (e.g. abridge text with "..." instead of removing all of it). Currently, we hard code a string length but we can't tell how much space is available, so the next easy fix is for us to add a user setting for this length.

@bpasero bpasero added workbench layout General VS Code workbench layout issues workbench-status Status bar and removed workbench layout General VS Code workbench layout issues labels Nov 11, 2017
@bpasero
Copy link
Member

bpasero commented Nov 17, 2017

#6651

@bpasero bpasero closed this as completed Nov 17, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality ux User experience issues workbench-status Status bar
Projects
None yet
Development

No branches or pull requests

6 participants