Smoke test: unable to create file app.js: Permission denied

[bpasero]

Quite often I see the smoke tests fail in this step:

vscode/test/smoke/src/areas/search/search.test.ts

Lines 16 to 20 in 3c4fdb5

	after(function () {
	const app = this.app as Application;
	cp.execSync('git checkout . --quiet', { cwd: app.workspacePathOrFolder });
	cp.execSync('git reset --hard HEAD --quiet', { cwd: app.workspacePathOrFolder });
	});

Which then seems to prevent the app from quitting:

vscode/test/smoke/src/utils.ts

Line 55 in 70e6d3f

await app.stop();

And then all following smoke tests fail:

The error seems to be: error: unable to create file app.js: Permission denied

As seen in:

• https://dev.azure.com/monacotools/Monaco/_build/results?buildId=133591&view=logs&j=672276a2-8d3a-5fab-615d-090c51352f92&t=0699ae84-7245-5a45-5eee-80b086af2725&l=31
• https://dev.azure.com/monacotools/Monaco/_build/results?buildId=133595&view=logs&j=672276a2-8d3a-5fab-615d-090c51352f92&t=316b23c8-21ca-5aab-3515-3225235af7bb&l=53

There could be a few reasons:

• the search process (RipGrep) holds onto the files (?)
• the file watcher (or any extension watcher) locks the file (?)

I wonder if we need to add some retry logic to the git command there.

[bpasero]

I have disabled the search smoke tests on Windows.

[roblourens]

the search process (RipGrep) holds onto the files (?)

I would not expect that to happen, so we can see if this helps

[roblourens]

Did the error go away after this? Could do a basic retry on those commands but I don't understand why search would break it

[bpasero]

Yes, I have not seen that error a single time since then.

[roblourens]

Added a retry. I guess that error can happen if there is another git operation happening at the same time. Dunno why that would happen. Please reopen if you see it again.