Cannot paste in search field because webview steals the paste

[alexdima]

Version: 1.61.0-insider (user setup)
Commit: 34861b8c8aa76b517f203743ad5b5d72ef5fcd81
Date: 2021-09-08T05:17:18.073Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042

• I was selfhosting, I checkout a PR, then another one, then another one...
• I then moved away from the PR webview editor to another editor (I don't remember exactly what steps I took)
• I can no longer paste in e.g. the search viewlet
• The reason is because the webview handler for Paste takes over.
• Here is the log output after enabling the trace log level and the keyboard troubleshooting command:

[2021-09-08 13:33:18.400] [renderer6] [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: KeyV, keyCode: 86, key: v
[2021-09-08 13:33:18.400] [renderer6] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: KeyV, keyCode: 52 ('V')
[2021-09-08 13:33:18.400] [renderer6] [info] [KeybindingService]: | Resolving ctrl+V
[2021-09-08 13:33:18.400] [renderer6] [info] [KeybindingService]: \ From 4 keybinding entries, matched editor.action.clipboardPasteAction, when: no when condition, source: built-in.
[2021-09-08 13:33:18.400] [renderer6] [trace] KeybindingService#dispatch Ctrl+V editor.action.clipboardPasteAction
[2021-09-08 13:33:18.400] [renderer6] [trace] CommandService#executeCommand editor.action.clipboardPasteAction
[2021-09-08 13:33:18.401] [renderer6] [trace] Executing Command 'editor.action.clipboardPasteAction' which has 6 bound.
[2021-09-08 13:33:18.401] [renderer6] [trace] Command 'editor.action.clipboardPasteAction' was handled by 'webview'.
[2021-09-08 13:33:18.631] [renderer6] [info] [KeybindingService]: + Storing single modifier for possible chord ctrl.
[2021-09-08 13:33:18.934] [renderer6] [info] [KeybindingService]: + Clearing single modifier due to 300ms elapsed.

The handler comes from here. It looks like there IWebviewService.activeWebview.isFocused evaluates to true even when the focus is somewhere else on the page.

Note: After clicking on the webview editor tab and back in the search viewlet, paste works again, so presumably IWebviewService.activeWebview.isFocused now returns false again correctly.

Giving this important as we constantly have people complaining about Paste not working and it is just a huge burden on me to always get these issues. If IWebviewService.activeWebview.isFocused cannot be trusted, the command implementation that you register could just look at the activeElement and make a decision based on that.

[IllusionMH]

It was already reported in #127881 and fixed.
Can't reproduce in latest Insiders.

Probably PR is not up to date with main?

[alexdima]

@IllusionMH Thanks for trying to reproduce, although I could not find any clear steps. I am on latest Insiders from 9hrs ago.

[TylerLeonhardt]

@alexdima duplicate of #132641 ?

[alexdima]

@TylerLeonhardt I have really tried to, but I do not understand the issue #110528 . From my latest understanding it seemed that pasting works, but Enter does not work for them. In any case, I could never reproduce anything.

My understanding comes from #110528 (comment) :

The problem is not in pasting some text in some filed, but in entering it as in input. With pressing ENTER key which is not applicable to markdown.

[rebornix]

Ran into this when following Live Preview's readme #134292