[Bug] File is listed in the "Changes" section even if it has no change

[wenfangdu]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: v1.61.0-insider
• OS Version: Windows 10

File encoding is UTF-8 with BOM.

Steps to Reproduce:

• 

• Notice the diff editor in the "Changes" (Not "Staged Changes") section shows no change, but the file is still listed there nonetheless.

[hamzawaleed0102]

@wenfangdu I'm unable to figure out whats wrong here 😕 I mean you added a new line and then staged the changes, then under diff viewer its reflecting that exact new line change. That's perfectly fine 🤔 . Pardon me if I missed something?

[wenfangdu]

@Lemmingh @hamzawaleed0102 Please see the updated issue, and remove the "confused" emoji if it's clear for you now.

[hamzawaleed0102]

@wenfangdu Oh got it, now makes sense. I'm not a pro in it so I need to see whether it's a bug or expected behaviour. After all changing the file encoding is still a change but sometimes not a visible one.

[wenfangdu]

@hamzawaleed0102 It's reproducible for new files with utf8bom encoding as well, i.e. no change for the encoding.

[Lemmingh]

OK. I can tell what happened. But I'm not sure who is to blame: VS Code, Git, or ConHost.

When invoking "Git: Stage Selected Ranges" (git.stageSelectedRanges), VS Code runs:

git hash-object --stdin -w --path test.ahk

Inspect the created object, and we can surprisingly find that it does not have BOM.

You can get a visual hint by:

git status --verbose

[Lemmingh]

/duplicate #111915

vscode/extensions/git/src/git.ts

Lines 1278 to 1283 in adee8fa

	async stage(path: string, data: string): Promise<void> {
	const child = this.stream(['hash-object', '--stdin', '-w', '--path', sanitizePath(path)], { stdio: [null, null, null] });
	child.stdin!.end(data, 'utf8');
	const { exitCode, stdout } = await exec(child);
	const hash = stdout.toString('utf8');

The encoding information is lost.

I can also reproduce the problem with GB 2312.

锟斤拷