Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show inline values in source when stepping through code #13424

Closed
weinand opened this issue Oct 10, 2016 · 7 comments
Closed

Show inline values in source when stepping through code #13424

weinand opened this issue Oct 10, 2016 · 7 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Oct 10, 2016

  1. in the debug protocol add a scope boundary (start, end position) to the scope object.
  2. implement this in node-debug2.
  3. VS Code starts to use that information to fix the hover experience by only showing a hover when inside the scope boundaries.
  4. node.debug2 and (node-debug) implement the one line 'preview' for objects and arrays. This is not a new protocol request but just improves what's get returned as the valueattribute in a Variables request for objects and arrays.
  5. VS Code implements the 'show inline values' feature as outlined in Debug: investigate how to present inline values in source when stepping through code #12256
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Oct 10, 2016
@weinand weinand added this to the October 2016 milestone Oct 10, 2016
@weinand weinand added the feature-request Request for new features or functionality label Oct 10, 2016
@weinand weinand modified the milestones: November 2016, October 2016 Oct 10, 2016
@isidorn
Copy link
Contributor

isidorn commented Nov 1, 2016

Assigning to @roblourens until this is implemented in the adapters. Once that is done assign back to me and I can pick it up in the UI

@isidorn isidorn assigned roblourens and unassigned isidorn Nov 1, 2016
@weinand
Copy link
Contributor Author

weinand commented Nov 1, 2016

I will create an issue for Rob in his repository.

roblourens added a commit to microsoft/vscode-chrome-debug-core that referenced this issue Nov 1, 2016
@roblourens
Copy link
Member

I added the scope locations to node-debug2. Will be in the next Insiders

@isidorn
Copy link
Contributor

isidorn commented Nov 23, 2016

Once we have this feature we should use it to market our new node2 debugger. It looks fancy so it can draw people to swtich to node2.

@weinand
Copy link
Contributor Author

weinand commented Nov 23, 2016

We will swap 'node' and 'node2' as soon as the node version used in electron supports CDP. Without that extension host debugging does not work in node2.

@isidorn
Copy link
Contributor

isidorn commented Nov 23, 2016

And when we do the switch we can use this feature as one of the user visible improvements

@isidorn isidorn modified the milestones: January 2017, November 2016 Dec 5, 2016
@egamma egamma mentioned this issue Dec 20, 2016
56 tasks
@isidorn
Copy link
Contributor

isidorn commented Jan 17, 2017

First version of this has been pushed to master.
If a debug adapter is providing scope ranges those will be used, otherwise we show inlinve values from lineNumber 0 to the current lineNumber of the stack frame

@isidorn isidorn closed this as completed Jan 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants