Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proposed check in terminal state change API #134376

Closed
Tyriar opened this issue Oct 4, 2021 · 1 comment
Closed

Remove proposed check in terminal state change API #134376

Tyriar opened this issue Oct 4, 2021 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues
Milestone
September 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 4, 2021

We finalized this API this iteration:

vscode/src/vs/workbench/api/common/extHost.api.impl.ts

Line 575 in 80ca5cf

checkProposedApiEnabled(extension);

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Oct 4, 2021
@Tyriar Tyriar added this to the September 2021 milestone Oct 4, 2021
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Oct 4, 2021
meganrogge added a commit that referenced this issue Oct 4, 2021
@meganrogge
fix #134376
d531d29
@meganrogge meganrogge mentioned this issue Oct 4, 2021
Merged
meganrogge added a commit that referenced this issue Oct 4, 2021
@meganrogge
fix #134376 (#134395)
71ca6e8
@sandy081
Copy link
Member

sandy081 commented Oct 6, 2021

Closing this as I see the PR is merged to release branch.

@sandy081 sandy081 closed this as completed Oct 6, 2021
Tyriar added a commit that referenced this issue Oct 6, 2021
@Tyriar
Remove proposed api check in terminal state event
4edb5c8 
Fixes #134376
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues
Projects
None yet
Milestone
September 2021
Development

No branches or pull requests
3 participants
@Tyriar @sandy081 @meganrogge