Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation problem #134907

Closed
ted1030 opened this issue Oct 12, 2021 · 3 comments
Closed

Translation problem #134907

ted1030 opened this issue Oct 12, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@ted1030
Copy link

ted1030 commented Oct 12, 2021

1.

dropdownActions.push(new SubmenuAction('split.profile', 'Split...', submenuActions));

image

Because 'Split...' doesn't be localized, the string is still not be translated.

2.

short: localize('moveToEditorShort', "Move into Editor Area")

value: localize('workbench.action.terminal.sizeToContentWidthInstance', "Toggle Size to Content Width"),

title: { value: localize('workbench.action.terminal.sizeToContentWidth', "Toggle Size to Content Width"), original: 'Toggle Size to Content Width' },

title: localize('workbench.action.terminal.sizeToContentWidthInstance', "Toggle Size to Content Width")

https://github.com/microsoft/vscode-loc/blob/87ef4f3cfb28df68e99858859288775d0f0efa70/i18n/vscode-language-pack-zh-hant/translations/main.i18n.json#L8184
The string "moveToEditorShort" and "workbench.action.terminal.sizeToContentWidthInstance"was translated in main.i18n.json, but it may be doesn't apply.
image

3.


Same as 1., there should be a localize().

@ted1030 ted1030 changed the title 'Spilit...' should be localized. Translation problem Oct 12, 2021
@Tyriar Tyriar added this to the October 2021 milestone Oct 19, 2021
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug L10N Translation issue terminal Integrated terminal issues and removed L10N Translation issue labels Oct 19, 2021
@Tyriar Tyriar removed the L10N Translation issue label Oct 19, 2021
meganrogge added a commit that referenced this issue Oct 20, 2021
@meganrogge
Copy link
Contributor

@Tyriar any idea why the translations wouldn't get applied for Size To Content Width?

@Tyriar
Copy link
Member

Tyriar commented Oct 20, 2021

@meganrogge if they're already in localize calls they probably just haven't got translated yet, nothing to do if that's the case.

@TylerLeonhardt
Copy link
Member

Language Pack releases are weekly and SLA on translations is like 2 weeks so usually if your translation doesn't show up in the next LP release, it'll show up in the one after.

@rzhao271 rzhao271 added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants