Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Edit in settings.json” fails to create key #134908

Open
mavenor opened this issue Oct 12, 2021 · 2 comments
Open

“Edit in settings.json” fails to create key #134908

mavenor opened this issue Oct 12, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@mavenor
Copy link

mavenor commented Oct 12, 2021

Issue Type: Bug

Description/TL;DR

The September 2021 (stable) release does not insert an earstwhile nonexistent JSON key after opening settings.json, when the "Edit in settings.json" link against any unmodified setting is clicked.
This seems to be for both "User" and "Workspace" scopes.

Expected Results

On clicking Edit in settings.json, the corresponding key (ID) is focused in the settings.json file, whether or not it was earstwhile present.

Actual Results

While settings.json always successfully opens each time, the corresponding key ID is only brought under cursor focus when it was already present in the file (i.e., previously set).

Steps to Reproduce

  1. Open Settings
  2. Find a setting that must be edited in the JSON file (e.g., editor.codeActionsOnSave) and has not been @modified.
  3. Click on “Edit in settings.json”
  4. The editor should open said file either to your last edit location, or to the first line.

VS Code version: Code 1.61.0 (ee8c7de, 2021-10-07T18:13:09.652Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

2021-10-12_19-24-25.mp4
System Info
Item Value
CPUs Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz (8 x 2400)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 7.85GB (1.95GB free)
Process Argv --crash-reporter-id 242528f1-feb2-4d92-8ed2-3ba6ac8503ac
Screen Reader no
VM 0%
Extensions: none
@mavenor
Copy link
Author

mavenor commented Oct 12, 2021

Possibly related bug: #127819
Differs because the author says the relevant key/default-value pair is inserted (i.e. no bug) when the settings scope is set to either "User" or "Workspace"
Not so for me.

@Gruntfuggly
Copy link

Gruntfuggly commented Nov 24, 2021

This is a bit of a show stopper when an extension only provides a single setting which needs to be set in the settings.json. You have to go back to the GUI view, copy the path of the setting and then go back to the json view and search for the setting.

I don't know if it is related, but the option to copy the default settings from the json to the user settings file is no longer present (as far as I can see).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

5 participants