Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlight markdown code blocks in notebooks #136693

Closed
mjbvz opened this issue Nov 8, 2021 · 1 comment
Closed

Syntax highlight markdown code blocks in notebooks #136693

mjbvz opened this issue Nov 8, 2021 · 1 comment
Assignees
@rebornix @mjbvz
Labels
feature-request Request for new features or functionality notebook-markdown verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2021

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 8, 2021

Steps to Reproduce:

  1. In a notebook
  2. Create a md cell with the contents:
```py
print(1 + 2)
```
  1. Switch to preview mode

Bug
There is no syntax highlighting
@mjbvz mjbvz added this to the November 2021 milestone Nov 8, 2021
@mjbvz mjbvz self-assigned this Nov 8, 2021
mjbvz added a commit to mjbvz/vscode that referenced this issue Nov 8, 2021
@mjbvz
Initial support for syntax highlighting md code blocks in notebooks
7648234 
For microsoft#136693
mjbvz added a commit that referenced this issue Nov 8, 2021
@mjbvz
Initial support for syntax highlighting md code blocks in notebooks
5e6d0e1 
For #136693
mjbvz added a commit that referenced this issue Nov 8, 2021
@mjbvz
Use editor font for markdown codeblocks
8b7aa3c 
For #136693
@kieferrm kieferrm mentioned this issue Nov 9, 2021
Closed
82 tasks
@mjbvz
Copy link
Contributor Author

mjbvz commented Nov 10, 2021

This should more or less be working now. Will handle any bug reports as they come in for this

@mjbvz mjbvz closed this as completed Nov 10, 2021
@mjbvz mjbvz added the feature-request Request for new features or functionality label Nov 10, 2021
This was referenced Nov 10, 2021
Closed
Closed
Closed
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Nov 29, 2021
@jrieken jrieken added the verified Verification succeeded label Nov 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality notebook-markdown verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
5 participants
@rebornix @jrieken @DonJayamanne @mjbvz and others