split doesn't work with default profile set to a contributed one #137243
Assignees
Labels
bug
Issue identified by VS Code Team member as probable bug
terminal-profiles
verified
Verification succeeded
Milestone
Comments
meganrogge
added
terminal-profiles
bug
|
same issue if you use the keybinding to split the terminal (ctrl shift 5) |
Tyriar
added a commit
that referenced
this issue
Nov 18, 2021
* Add a bunch of tests * tweak tests * add profile tests, now breaking (no profiles showing up) * uncomment tests * update expected * fix test * merge * all passing * bunch of improvements * improve readability * all should be passing and cleaned up * all passing * fix #137243 and clean-up * remove .only * fix #137247 * get rid of enum * see if this fixes timing issue * use keybinding for show terminal instead * remove delay, implement better accept function * get rid of unneeded index * try something else * wait for empty editor to be active * remove .only * decrease redundancy in names * re-add xterm selector * try something else * undo change that broke things worse * add terminal-tabs test * all tabs tests passing locally * kill all * await before running each * fix tests * remove .only * try waiting for focused xterm * remove .only * clean up * 🧹 * fix profiles tests by using this.app.props * revert to use default shell * re-add conditional * Get tests passing on WebKit On WebKit the smoke tests were failing because the quick pick was triggering a focus event on the terminal after the blur event had already happened, this caused the view service to think the terminal was still focused when it wasn't. The fix was to reset the context key also in IViewsService.closeView. * Safari -> WebKit * Prefer arrow functions * remove beforeEach timeout * add timeouts to contributed profile tests * add terminal editor tests, fix #137377 * add a bunch of tests * refactor * get rid of profile specific command * more polish * refactor getTabs -> assertTerminalGroups * fix failing test * more polish * remove .only * add assertSingleTab * remove unused import * fix error * fix more failures * more changes * fix almost all except for plus button * fix failing plus button test * all passing * modify error that gets thrown * modify error message again * remove unused wildcard/ ANY_NAME, fix icon code * fix icon code * large refactor, improvements * finish polish * 1 failing * get test to pass Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this issue
Nov 25, 2022
* Add a bunch of tests * tweak tests * add profile tests, now breaking (no profiles showing up) * uncomment tests * update expected * fix test * merge * all passing * bunch of improvements * improve readability * all should be passing and cleaned up * all passing * fix microsoft#137243 and clean-up * remove .only * fix microsoft#137247 * get rid of enum * see if this fixes timing issue * use keybinding for show terminal instead * remove delay, implement better accept function * get rid of unneeded index * try something else * wait for empty editor to be active * remove .only * decrease redundancy in names * re-add xterm selector * try something else * undo change that broke things worse * add terminal-tabs test * all tabs tests passing locally * kill all * await before running each * fix tests * remove .only * try waiting for focused xterm * remove .only * clean up * 🧹 * fix profiles tests by using this.app.props * revert to use default shell * re-add conditional * Get tests passing on WebKit On WebKit the smoke tests were failing because the quick pick was triggering a focus event on the terminal after the blur event had already happened, this caused the view service to think the terminal was still focused when it wasn't. The fix was to reset the context key also in IViewsService.closeView. * Safari -> WebKit * Prefer arrow functions * remove beforeEach timeout * add timeouts to contributed profile tests * add terminal editor tests, fix microsoft#137377 * add a bunch of tests * refactor * get rid of profile specific command * more polish * refactor getTabs -> assertTerminalGroups * fix failing test * more polish * remove .only * add assertSingleTab * remove unused import * fix error * fix more failures * more changes * fix almost all except for plus button * fix failing plus button test * all passing * modify error that gets thrown * modify error message again * remove unused wildcard/ ANY_NAME, fix icon code * fix icon code * large refactor, improvements * finish polish * 1 failing * get test to pass Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: