Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook cells all show semantics based on the first cell text contents (web only) #8427

Closed
joaomoreno opened this issue Dec 2, 2021 · 11 comments
Labels
notebook-intellisense Intellisense & other language features in notebook cells for any language upstream-pylance Blocked on upstream Pylance

Comments

@joaomoreno
Copy link
Member

Sorry if I'm filling this in the wrong place

On https://insiders.vscode.dev/github/joaomoreno/aoc2021, with: Python, Pylance and vscode-pyodide

recording (17)

@joaomoreno
Copy link
Member Author

This might just be a bug for https://github.com/joyceerhl/vscode-pyolite.

The hover on the first line of the second cell talks about the first line of the first cell. 🤔

image

@joaomoreno
Copy link
Member Author

This is so random, I can find no reason to it.

Here's insiders (left) vs stable (right). Notice the highlights on the second cell of each page. Furthermore, notice the coloring on the second cell on stable (right).

image

@joyceerhl
Copy link
Contributor

@joaomoreno do you have the Pylance extension installed and what happens if you disable it? I remember some semantic highlighting tokenization issues that the Jupyter team was working to resolve.

@joaomoreno
Copy link
Member Author

Disabling Pylance fixes it, but of course it also removes all smart Python functionality.

@joaomoreno
Copy link
Member Author

The bug is all cells have semantic features (hover, word highlighting) based on the contents of the first cell.

image

@joaomoreno joaomoreno changed the title Strange coloring and hover on first line Notebook cells all show semantics based on the first cell text contents Dec 2, 2021
@IanMatthewHuff IanMatthewHuff transferred this issue from microsoft/vscode Dec 2, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Dec 2, 2021

This is using the web extension. We're not enabled there (yet). Pylance will probably have to resolve this.

@rchiodo rchiodo changed the title Notebook cells all show semantics based on the first cell text contents Notebook cells all show semantics based on the first cell text contents (web only) Dec 2, 2021
@joaomoreno
Copy link
Member Author

This is using the web extension. We're not enabled there (yet). Pylance will probably have to resolve this.

Should we move the issue to another repo then?

@rchiodo rchiodo added upstream-pylance Blocked on upstream Pylance notebook-intellisense Intellisense & other language features in notebook cells for any language and removed needs-triage labels Dec 6, 2021
@rchiodo rchiodo removed their assignment Dec 6, 2021
@dynamicwebpaige
Copy link

Related to: microsoft/pylance-release#1874

@joaomoreno
Copy link
Member Author

joaomoreno commented Dec 10, 2021

@dynamicwebpaige Oh wow. I am surprised such an ugly issue has been known for that long.

@rchiodo should we close this one and move the discussion over to microsoft/pylance-release#1874?

@rchiodo
Copy link
Contributor

rchiodo commented Dec 10, 2021

I'd rather leave this one open as motivation for us to actually support web in the jupyter extension. Pylance already has their own bug.

@amunger
Copy link
Contributor

amunger commented Dec 5, 2022

looks like this is fixed

@amunger amunger closed this as completed Dec 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook-intellisense Intellisense & other language features in notebook cells for any language upstream-pylance Blocked on upstream Pylance
Projects
None yet
Development

No branches or pull requests

8 participants