Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command links in notebook output not working #138666

Closed
joyceerhl opened this issue Dec 8, 2021 · 2 comments
Closed

Command links in notebook output not working #138666

joyceerhl opened this issue Dec 8, 2021 · 2 comments
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Dec 8, 2021

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.63-insider
  • OS Version: Edge on Windows (vscode.dev)

Steps to Reproduce:

  1. Open a github issues notebook
  2. Don't sign in and run a relatively complex query, get the message about needing to sign in due to the api rate limit
  3. 🐛 clicking on the link to sign in does nothing
    image

fyi @jrieken since this impacts the getting started experience with GitHub Issues notebooks--could the extension request authentication with createIfNone when we hit this case?

@jrieken
Copy link
Member

jrieken commented Dec 9, 2021

could the extension request authentication with createIfNone when we hit this case?

I believe the extension cannot know that we hit this case. I believe it's a bug that command links don't work, waiting for @rebornix to confirm tho

rebornix added a commit that referenced this issue Dec 20, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Jan 7, 2022

@rebornix Was this fixed by your commit? Should we only enable command links in trusted workspaces?

@mjbvz mjbvz added this to the February 2022 milestone Jan 19, 2022
@mjbvz mjbvz closed this as completed in 7874a69 Feb 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

No branches or pull requests

5 participants
@rebornix @jrieken @mjbvz @joyceerhl and others