Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable starting extension host with --expose-gc #139139

Closed
roblourens opened this issue Dec 14, 2021 · 1 comment · Fixed by #139242
Closed

Enable starting extension host with --expose-gc #139139

roblourens opened this issue Dec 14, 2021 · 1 comment · Fixed by #139242
Assignees
@roblourens @alexdima
Labels
extension-host Extension host issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2022

Comments

@roblourens
Copy link
Member

The Jupyter extension runs memory usage tests, but they don't provide useful results unless they can force a GC. Starting a node process with --expose-gc enables the api global.gc() to do this.

Can we enable spawning the extension host with this flag? Or is there some creative backdoor way that an extension can do this already?

vscode/src/vs/workbench/services/extensions/electron-browser/localProcessExtensionHost.ts

Line 250 in 648e355

opts.execArgv = [

We could always set it when running extension tests. Or, add a flag/environment variable that vscode can be started with to enable this. NODE_OPTIONS apparently can't be used for --expose-gc

cc
@rchiodo
@alexdima
Copy link
Member

We could always set it when running extension tests

👍 PR welcome.

@alexdima alexdima added extension-host Extension host issues feature-request Request for new features or functionality labels Dec 15, 2021
@alexdima alexdima added this to the Backlog milestone Dec 15, 2021
roblourens added a commit that referenced this issue Dec 15, 2021
@roblourens
Spawn EH process with --expose-gc when in extension tests.
724181f 
Fix #139139
@roblourens roblourens mentioned this issue Dec 15, 2021
Merged
@alexdima alexdima modified the milestones: Backlog, January 2022 Dec 16, 2021
@alexdima alexdima added the verification-needed Verification of issue is requested label Dec 16, 2021
@jrieken jrieken added the verified Verification succeeded label Jan 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@alexdima alexdima

Labels
extension-host Extension host issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2022
Development

Successfully merging a pull request may close this issue.

Spawn EH process with --expose-gc when in extension tests. microsoft/vscode
4 participants
@roblourens @jrieken @alexdima and others