Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell integration: Create "Terminal: Go to Recent Directory" command #139402

Closed
Tyriar opened this issue Dec 17, 2021 · 4 comments
Closed

Shell integration: Create "Terminal: Go to Recent Directory" command #139402

Tyriar opened this issue Dec 17, 2021 · 4 comments
Assignees
Labels
plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc.
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 17, 2021

Parent issue #133084

Blocked on:

Notes:

  • This will present a quick pick of all recent terminal directories
  • This should share code with the command history command as both will present a list and send text to the shell
  • Should have smoke tests
  • Considerations:
    • Do we have a maximum of entries we track?
    • Should this be sorted by recency of frequency?
    • Can we avoid settings for this feature?
@Tyriar
Copy link
Member Author

Tyriar commented Jan 7, 2022

We also want to check to see if there is currently a command being input and send ctrl+c if so (Terminate batch job might cause problems on Windows)

@Tyriar
Copy link
Member Author

Tyriar commented Jan 7, 2022

Something else to think about, pretty sure we want to persist this information, but should it be persisted globally or per workspace?

@meganrogge
Copy link
Contributor

same question - should this be per terminal instance? it is right now

@Tyriar
Copy link
Member Author

Tyriar commented Jan 13, 2022

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Development

No branches or pull requests

2 participants