Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell integration: Frequency sorting of recent directories may be broken on Windows #141008

Closed
Tyriar opened this issue Jan 19, 2022 · 5 comments · Fixed by #141083
Closed

Shell integration: Frequency sorting of recent directories may be broken on Windows #141008

Tyriar opened this issue Jan 19, 2022 · 5 comments · Fixed by #141083
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
February 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 19, 2022

#139402 (comment)
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. labels Jan 19, 2022
@Tyriar Tyriar added this to the January 2022 milestone Jan 19, 2022
@Tyriar Tyriar mentioned this issue Jan 19, 2022
Closed
@Tyriar Tyriar changed the title Shell integration: Sorting of recent directories may be broken on Windows Shell integration: Frequency sorting of recent directories may be broken on Windows Jan 19, 2022
@meganrogge
Copy link
Contributor

I believe this was broken at one point, but is now working correctly.

Screen Shot 2022-01-19 at 5 11 06 PM

@Tyriar
Copy link
Member Author

Tyriar commented Jan 20, 2022

Still seems broken for me on Windows, I'll look into it for #141083

@Tyriar Tyriar reopened this Jan 20, 2022
@Tyriar Tyriar assigned Tyriar and unassigned meganrogge Jan 20, 2022
Tyriar added a commit that referenced this issue Jan 20, 2022
@Tyriar
Fix cwd ordering
55d0cd1 
Fixes #141008
@Tyriar Tyriar mentioned this issue Jan 20, 2022
Merged
@meganrogge
Copy link
Contributor

verify that the cwds are sorted in terms of the frequency that you've cd'd into them

@rzhao271
Copy link
Contributor

rzhao271 commented Jan 28, 2022 •
edited

For me, the sorting seems to be by most recent first.
I ran cd <absolute path to vscode repo dir> multiple times.
Edit: the order might be the wrong way #141083 (comment)

Demo

@rzhao271 rzhao271 reopened this Jan 28, 2022
@rzhao271 rzhao271 added the verification-found Issue verification failed label Jan 28, 2022
@Tyriar Tyriar removed the verification-found Issue verification failed label Feb 3, 2022
@Tyriar Tyriar closed this as completed in 5d5d715 Feb 23, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Feb 23, 2022

The "current session" section is now in last accessed order just like the new "previous session" section

@rzhao271 rzhao271 added the verified Verification succeeded label Feb 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

Successfully merging a pull request may close this issue.

Shell integration tests and refactors microsoft/vscode
5 participants
@deepak1556 @Tyriar @rzhao271 @meganrogge and others