window.tabs after vscode.open command is not up to date

[bpasero]

I just pushed a test for asserting vscode.open command properly applies the ViewColumn argument and my initial idea was to use the window.tabs API for that purpose, but as it turns out, awaiting executeCommand and then calling window.tabs does not work, maybe (?) because of the micro queue that puts the events at the end?

Using window.activeTextEditor.viewColumn however seems to work, and I wonder if we need to make window.tabs also work so that extensions see a consistent picture.

If we don't want to drop the micro task then maybe those commands that leverage editors need to await the tabs model being synced back to the extension host?

//cc @jrieken

[lramos15]

This is interesting as I feel like the tab tests do something similar but they use open and show text document for the most part.

For example we use execute command to get a diff here and then check windows.tab

vscode/extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts

Lines 394 to 397 in 9ce72d2

	await commands.executeCommand('vscode.diff', leftDiff, rightDiff, 'Diff', { viewColumn: ViewColumn.Three, preview: false });
	const tabs = window.tabs;
	assert.strictEqual(tabs.length, 5);

[bpasero]

@lramos15 but you are not testing for activeTab, just add this and it fails after line 397:

assert.strictEqual(window.activeTab?.viewColumn, ViewColumn.Three);

[lramos15]

@bpasero I just tested this again now that we removed microtask and it's still incorrect. Will have to dig deeper but that doesn't seem like it was it.

[bpasero]

Is it possible that the executeCommand simply returns to the extension host before you were pushing the updated tabs model to the extension host? Maybe there is a missing await in vscode.open that does not exist in the other ways for opening.

[lramos15]

I thin I must've messed up testing / fixed it with my if (!editorIndex) fix. Seems to work now and I added a test. Don't know if you want to update your vscode.open tests as well

[bpasero]

verified via 6dee30b