Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal in editor area not restored after vs code restart. #140429

Closed
sanjaytkumbhar opened this issue Jan 10, 2022 · 1 comment · Fixed by #151852
Closed

Terminal in editor area not restored after vs code restart. #140429

sanjaytkumbhar opened this issue Jan 10, 2022 · 1 comment · Fixed by #151852
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Milestone
July 2022

Comments

@sanjaytkumbhar
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.63.2
  • OS Version: Windows 11

Steps to Reproduce:

  1. Start VS code without extensions :
    code-insiders --disable-extensions
  2. Create new terminal in editor :
    CTRL+SHIFT+P -> Terminal:Create New Terminal in Editor area to the side.
  3. Close vs code by clicking on 'x' button on app top right of the WIndow.
  4. Re-open vs code, see that the terminal in editor area is not restored.

Notes:

  1. Persistent sessions value set
    "terminal.integrated.persistentSessionReviveProcess": "onExitAndWindowClose"
  2. No issues with the terminals in panel area. Terminal are restored correctly when vs code is restarted. Issue only with terminals opened in editor area,
@meganrogge meganrogge added the terminal-persistence Relating to process reconnection or process revive label Jan 11, 2022
ssigwart added a commit to ssigwart/vscode that referenced this issue Jun 12, 2022
@ssigwart
Fix terminals in editor area not reloading
71c15ea 
- Closes microsoft#140429
- This isn't perfect because it just reopens then without setting the original location, but at least it reloads them.
@ssigwart ssigwart mentioned this issue Jun 12, 2022
Merged
@ssigwart
Copy link
Contributor

I found the issue and implemented a fix in #151852. It doesn't preserve the location of the editor, but at least restores them.

@Tyriar Tyriar modified the milestones: June 2022, Backlog Jun 13, 2022
@Tyriar Tyriar modified the milestones: Backlog, July 2022 Jul 6, 2022
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed confirmation-pending labels Jul 6, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 6, 2022
@andreamah andreamah added the verified Verification succeeded label Jul 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Fix terminals in editor area not reloading ssigwart/vscode
6 participants
@ssigwart @Tyriar @meganrogge @andreamah @sanjaytkumbhar @VSCodeTriageBot