Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's better to follow symlinks recursively in Linux launch script #14044

Closed
ZHOUYue67 opened this issue Oct 20, 2016 · 0 comments · Fixed by #14046
Closed

It's better to follow symlinks recursively in Linux launch script #14044

ZHOUYue67 opened this issue Oct 20, 2016 · 0 comments · Fixed by #14046
Assignees
@Tyriar
Labels
linux Issues with VS Code on Linux
Milestone
October 2016

Comments

@ZHOUYue67
Copy link
Contributor

ZHOUYue67 commented Oct 20, 2016 •
edited
Loading

The Linux launch script (bin/code) of vscode finds VSCODE_PATH by resolving the path of itself:

VSCODE_PATH="$(dirname $(readlink $0))/.."

Some users might want to use symlinks that link to symlink of bin/code, then this script will fail to launch vscode, because it only follows one layer of symlinks. To solve this problem, simply add -f option to readlink to resolve the symlinks recursively:

VSCODE_PATH="$(dirname $(readlink -f $0))/.."

A pull request is on the way.
ZHOUYue67 added a commit to ZHOUYue67/vscode that referenced this issue Oct 20, 2016
@ZHOUYue67
Fix microsoft#14044: follow symlinks recursively in Linux launch script
a173969
@ZHOUYue67 ZHOUYue67 changed the title It's better to follow symlink recursively in Linux launch script It's better to follow symlinks recursively in Linux launch script Oct 20, 2016
@ZHOUYue67 ZHOUYue67 mentioned this issue Oct 20, 2016
Merged
@Tyriar Tyriar added this to the October 2016 milestone Oct 20, 2016
@Tyriar Tyriar added the linux Issues with VS Code on Linux label Oct 20, 2016
@Tyriar Tyriar self-assigned this Oct 20, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@ZHOUYue67
Fix microsoft#14044: follow symlinks recursively in Linux launch script
eeb9fe9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
linux Issues with VS Code on Linux
Projects
None yet
Milestone
October 2016
Development

Successfully merging a pull request may close this issue.

Follow symlinks recursively in Linux launch script ZHOUYue67/vscode
2 participants
@Tyriar @ZHOUYue67